[Archivesspace_Users_Group] Any progress on AR1134 (ingesting EAD <dimensions> and <physfacet>)?

Bowers, Kate A. kate_bowers at harvard.edu
Mon Mar 28 11:32:42 EDT 2016 

On March 14, 2016 Chris Fitzpatrick wrote:
“Great. So, does everyone agree we can mark AR-1270<https://urldefense.proofpoint.com/v2/url?u=https-3A__archivesspace.atlassian.net_browse_AR-2D1270&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=s8DH3bfjjrDba7PSyZpm65efg6lHvo13gU8yI-V-ba0&s=62dgLprb3VBa1YkOBw5P6EYDK1tcHAgNhs31gNUBM0k&e=> as Accepted? Or is there some outstanding issue?”

And I responded later that day:

“Something broke...”

Is there any information on where this fix now stands?
I’ve just added a comment replicating my email about what was broken and attached the test file I used to find the broken bit here: https://archivesspace.atlassian.net/browse/AR-1270

Thanks!

Kate Bowers
Collections Services Archivist for Metadata, Systems, and Standards
Harvard University Archives
kate_bowers at harvard.edu<mailto:megan_sniffin-marinoff at harvard.edu>
617.496.2713
voice: (617) 998-5238
fax: (617) 495-8011
web: http://nrs.harvard.edu/urn-3:hul.eresource:archives
Twitter: @k8_bowers


From: archivesspace_users_group-bounces at lyralists.lyrasis.org [mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org] On Behalf Of Bowers, Kate A.
Sent: Monday, March 14, 2016 9:09 AM
To: Archivesspace Users Group
Subject: Re: [Archivesspace_Users_Group] Any progress on AR1134 (ingesting EAD <dimensions> and <physfacet>)?




Something broke--



Before this fix, a <physdesc> lacking an <extent> created a Physical Description type note with mixed content.  Now, a component lacking an extent results only in the dimensions and physical facet type notes, leaving the PCDATA in the <physdesc> behind entirely.



See http://test.archivesspace.org/resources/58/edit#tree::archival_object_11931<https://urldefense.proofpoint.com/v2/url?u=http-3A__test.archivesspace.org_resources_58_edit-23tree-3A-3Aarchival-5Fobject-5F11931&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=P2ic1b0Qb4t99rwOiZyLUW3baNdmnrdwlIwjPtHO1w0&s=NHdPdsEwclASCyB7tIwmuT-UP2sQJFGjd0tL_N1cmSA&e=>


            <c level="item">
                <did>
                    <unittitle>No extent, single dimensions, single physfacet</unittitle>
                    <physdesc>1 photograph
                                       <physfacet>gelatin silver</physfacet>
                                       <dimensions>8 x 10 inches</dimensions></physdesc>
                </did>
            </c>



Also attaching my test EAD.

Kate Bowers
Collections Services Archivist for Metadata, Systems, and Standards
Harvard University Archives
Cambridge, Massachusetts, USA
voice: (617) 384-7787
fax: (617) 495-8011
kate_bowers at harvard.edu<mailto:kate_bowers at harvard.edu>



________________________________
From: archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org> <archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org>> on behalf of Chris Fitzpatrick <Chris.Fitzpatrick at lyrasis.org<mailto:Chris.Fitzpatrick at lyrasis.org>>
Sent: Monday, March 14, 2016 5:00 AM
To: Archivesspace Users Group
Subject: Re: [Archivesspace_Users_Group] Any progress on AR1134 (ingesting EAD <dimensions> and <physfacet>)?


Hi Kate,



Great. So, does everyone agree we can mark AR-1270<https://urldefense.proofpoint.com/v2/url?u=https-3A__archivesspace.atlassian.net_browse_AR-2D1270&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=s8DH3bfjjrDba7PSyZpm65efg6lHvo13gU8yI-V-ba0&s=62dgLprb3VBa1YkOBw5P6EYDK1tcHAgNhs31gNUBM0k&e=> as Accepted? Or is there some outstanding issue?



b,chris.


Chris Fitzpatrick | Developer, ArchivesSpace
Skype: chrisfitzpat  | Phone: 918.236.6048
http://archivesspace.org/

________________________________
From: archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org> <archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org>> on behalf of Bowers, Kate A. <kate_bowers at harvard.edu<mailto:kate_bowers at harvard.edu>>
Sent: Sunday, March 13, 2016 4:12 PM
To: Archivesspace Users Group
Subject: Re: [Archivesspace_Users_Group] Any progress on AR1134 (ingesting EAD <dimensions> and <physfacet>)?



Chris:



Yes, thanks! It is working there (see http://test.archivesspace.org/resources/57#tree::resource_57<https://urldefense.proofpoint.com/v2/url?u=http-3A__test.archivesspace.org_resources_57-23tree-3A-3Aresource-5F57&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=s8DH3bfjjrDba7PSyZpm65efg6lHvo13gU8yI-V-ba0&s=1ikF6H9FXBTD7GFRpRQeBTQLyU-ShpBpb3dYSiC9c2U&e=>)



Bravo!


Kate

Kate Bowers
Collections Services Archivist for Metadata, Systems, and Standards
Harvard University Archives
Cambridge, Massachusetts, USA
voice: (617) 384-7787
fax: (617) 495-8011
kate_bowers at harvard.edu<mailto:kate_bowers at harvard.edu>



________________________________
From: archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org> <archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org>> on behalf of Chris Fitzpatrick <Chris.Fitzpatrick at lyrasis.org<mailto:Chris.Fitzpatrick at lyrasis.org>>
Sent: Tuesday, March 8, 2016 2:03 PM
To: Archivesspace Users Group
Subject: Re: [Archivesspace_Users_Group] Any progress on AR1134 (ingesting EAD <dimensions> and <physfacet>)?



Hi,



Ok, sorry about the altrender red herring. I just saw that was added to the test data <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_archivesspace_archivesspace_pull_312_files-23diff-2D5c89302e37d581e4567408acd9ed857cR70&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=kDADGiSthQwsrLj7T4KOIzAkW_6uJvzkrlKXoL6yxLo&e=>

and assume that was the hold up, but didn't look close enough. My bad...



So...now I'm confused, since this seems to be reported as fixed, then not fixed, then fixed, etc.

Kate are you testing against http://test.archivesspace.org<https://urldefense.proofpoint.com/v2/url?u=http-3A__test.archivesspace.org&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=NjebfUarBp8u9M4kgfWrP5MTtnseR6LOMZb1E9B5TQY&e=> ?

The test site has the latest nightly build, so if it's fixed, it'll show it here.



b,chris.












Chris Fitzpatrick | Developer, ArchivesSpace
Skype: chrisfitzpat  | Phone: 918.236.6048
http://archivesspace.org/

________________________________
From: archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org> <archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org>> on behalf of Dallas Pillen <djpillen at umich.edu<mailto:djpillen at umich.edu>>
Sent: Tuesday, March 08, 2016 7:54 PM
To: Archivesspace Users Group
Subject: Re: [Archivesspace_Users_Group] Any progress on AR1134 (ingesting EAD <dimensions> and <physfacet>)?

Hi all,

We here at the Bentley submitted that PR a few months ago to fix this physdesc mapping issue. As far as I can tell, there is no requirement to have an @altrender="part" attribute; rather, the PR was meant to make ArchivesSpace ingest physdescs in the same way that it exports them. There was some discussion about that on the PR here: https://github.com/archivesspace/archivesspace/pull/312<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_archivesspace_archivesspace_pull_312&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=ihqOYnu-Rzj2mCxOloEATspDvCJh8iYNFPqvoY3MmMw&e=>
[https://avatars1.githubusercontent.com/u/7026330?v=3&s=400]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_archivesspace_archivesspace_pull_312&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=ihqOYnu-Rzj2mCxOloEATspDvCJh8iYNFPqvoY3MmMw&e=>

AR-1134 and AR-1270: account for all physdesc subtags in EAD import by walkerdb · Pull Request #312 · archivesspace/archivesspace<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_archivesspace_archivesspace_pull_312&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=ihqOYnu-Rzj2mCxOloEATspDvCJh8iYNFPqvoY3MmMw&e=>
github.com
JIRA references: AR-1134, AR-1270 We (at the Bentley Historical Library) wrote up a local fix for these issues, and thought we'd pass it upstream. Happy to refactor / edit if anything seems off! ...


Basically, the ArchivesSpace EAD exporter exports an extent record's "portion" value as an altrender attribute of "whole" or "part," so the PR that we submitted checks for an altrender attribute and, if it finds one AND the altrender value is "part," the imported extent will have a portion of "part." Otherwise, in cases where there is no altrender attribute or the altrender attribute is some value other than "part," the extent record's portion is set to "whole." See here: https://github.com/archivesspace/archivesspace/blob/master/backend/app/converters/ead_converter.rb#L248-L252<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_archivesspace_archivesspace_blob_master_backend_app_converters_ead-5Fconverter.rb-23L248-2DL252&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=D3APK7AUgvwTXcD41jwUHi9fruEG88H6wEBXLkVldk8&e=>

I just tested importing an EAD with several physdesc variations (some with altrenders, some without; some with multiple extents, a physfacet and a dimensions element, some with only a single extent or a single physfacet, etc.) and it imported as expected (physdescs with an extent + other elements create only an extent record and no duplicate notes; physdescs with only non-extent elements create physical facet, physical dimensions, or physical description notes, and so on). The imported resource is here: http://test.archivesspace.org/resources/54<https://urldefense.proofpoint.com/v2/url?u=http-3A__test.archivesspace.org_resources_54&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=pUFDUIHsoWD9cQJAq7dWz_vmfCL4hFvwxCwmbGTiiFk&e=>

As far as I can tell, this issue has been fixed but it just has not made it into an official release (the PR was accepted last November; v. 1.4.2 came out in October).

I uploaded the EAD that I just tested to the JIRA issue as physdesc_variations_test.xml.

On Tue, Mar 8, 2016 at 1:37 PM, Bowers, Kate A. <kate_bowers at harvard.edu<mailto:kate_bowers at harvard.edu>> wrote:
I don’t understand the reasoning behind this at all.  Why would a <physdesc> that has <dimensions> or <physfacet>  only ever be a “part”?  Is there any documentation of the EAD ingest where this is recorded?

Thanks!

Kate



Kate Bowers
Collections Services Archivist for Metadata, Systems, and Standards
Harvard University Archives
kate_bowers at harvard.edu<mailto:megan_sniffin-marinoff at harvard.edu>
617.496.2713<tel:617.496.2713>
voice: (617) 384-7787<tel:%28617%29%20384-7787>
fax: (617) 495-8011<tel:%28617%29%20495-8011>
web: http://nrs.harvard.edu/urn-3:hul.eresource:archives
Twitter: @k8_bowers


From: archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org> [mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org>] On Behalf Of Chris Fitzpatrick
Sent: Tuesday, March 08, 2016 11:50 AM

To: Archivesspace Users Group
Subject: Re: [Archivesspace_Users_Group] Any progress on AR1134 (ingesting EAD <dimensions> and <physfacet>)?






Hi,



We did our March sprint planning<https://urldefense.proofpoint.com/v2/url?u=https-3A__archivesspace.atlassian.net_browse_AR-2D1134&d=CwMFAw&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=ZiA4lKtFjjvXBp_jnGl60EM_epYBy-o_l1XqJtuMclc&s=WA1pOD-hlNR3C4LiqJXWMQMKvaWY7uuD6sewvznDQqw&e=> yesterday afternoon and this feature request was not included in the sprint.



However, looking through this ticket, it looks like a pull request was already submitted and accepted that adds this feature. The key is that the physdesc has to have an @altrender = "part".



If someone is wanting to submit a PR to remove the @altrender requirement to the feature, we would certainly look at it.



b,chris.

________________________________
From: archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org> <archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org>> on behalf of Bowers, Kate A. <kate_bowers at harvard.edu<mailto:kate_bowers at harvard.edu>>
Sent: Tuesday, March 08, 2016 5:16 PM
To: Archivesspace Users Group
Subject: Re: [Archivesspace_Users_Group] Any progress on AR1134 (ingesting EAD <dimensions> and <physfacet>)?


What are the next steps toward getting this bug fixed?



I have just uploaded a document to https://archivesspace.atlassian.net/browse/AR-1134<https://urldefense.proofpoint.com/v2/url?u=https-3A__archivesspace.atlassian.net_browse_AR-2D1134&d=CwMFAw&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=ZiA4lKtFjjvXBp_jnGl60EM_epYBy-o_l1XqJtuMclc&s=WA1pOD-hlNR3C4LiqJXWMQMKvaWY7uuD6sewvznDQqw&e=>

It includes:

1) Undesirable behavior (current behavior)

2) Desired behavior

3) Multiple screenshots from my testing



Thanks!



Kate



Kate Bowers

Collections Services Archivist for Metadata, Systems, and Standards

Harvard University Archives

kate_bowers at harvard.edu<mailto:megan_sniffin-marinoff at harvard.edu>

617.496.2713<tel:617.496.2713>

voice: (617) 384-7787<tel:%28617%29%20384-7787>

fax: (617) 495-8011<tel:%28617%29%20495-8011>

web: http://nrs.harvard.edu/urn-3:hul.eresource:archives

Twitter: @k8_bowers





From: archivesspace_users_group-bounces at lyralists.lyrasis.org<mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org> [mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org] On Behalf Of Bowers, Kate A.
Sent: Thursday, March 03, 2016 1:53 PM
To: Archivesspace Users Group
Subject: [Archivesspace_Users_Group] Any progress on AR1134 (ingesting EAD <dimensions> and <physfacet>)?




I have been told that this issue is in Sprint 19, the current sprint, but the status is "icebox".  What does "icebox" mean?

https://archivesspace.atlassian.net/browse/AR-1134?jql=text%20~%20%22Dimensions%22<https://urldefense.proofpoint.com/v2/url?u=https-3A__archivesspace.atlassian.net_browse_AR-2D1134-3Fjql-3Dtext-2520-7E-2520-2522Dimensions-2522&d=CwMFAw&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=ZiA4lKtFjjvXBp_jnGl60EM_epYBy-o_l1XqJtuMclc&s=ARHzzWuvH_v-yAPrcjOGhqtFBXBLvZBR0M8aHFmFrIc&e=>

One of the reasons we ar particularly interested is that many EAD descriptions of photo collections make particularly heavy use of <physfacet> and <dimensions>.

Thanks!

Kate


Kate Bowers
Collections Services Archivist for Metadata, Systems, and Standards
Harvard University Archives
Cambridge, Massachusetts, USA
voice: (617) 384-7787<tel:%28617%29%20384-7787>
fax: (617) 495-8011<tel:%28617%29%20495-8011>
kate_bowers at harvard.edu<mailto:kate_bowers at harvard.edu>

_______________________________________________
Archivesspace_Users_Group mailing list
Archivesspace_Users_Group at lyralists.lyrasis.org<mailto:Archivesspace_Users_Group at lyralists.lyrasis.org>
http://lyralists.lyrasis.org/mailman/listinfo/archivesspace_users_group<https://urldefense.proofpoint.com/v2/url?u=http-3A__lyralists.lyrasis.org_mailman_listinfo_archivesspace-5Fusers-5Fgroup&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=cvaKvOno6vplp6fHDciISYW3VKc2n46dVwHrxMYG2dI&e=>



--
Dallas Pillen
Assistant Archivist for Metadata and Digital Projects

[https://webapps.lsa.umich.edu/dean/lsa_emails/bentley-sig-em.png]
  Bentley Historical Library<https://urldefense.proofpoint.com/v2/url?u=http-3A__bentley.umich.edu_&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=Ewo-vzINAOezy4Xo1CfaCSjRkEgbFa_Da3CpQpIztkc&e=>
  1150 Beal Avenue
  Ann Arbor, Michigan 48109-2113
  734.647.3559
  Twitter<https://urldefense.proofpoint.com/v2/url?u=https-3A__twitter.com_umichBentley&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=W5iAeICic5nCia2My-EC7zPIcKzSBgAIcweJleRai9Y&e=> Facebook <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.facebook.com_bentleyhistoricallibrary&d=CwMF-g&c=WO-RGvefibhHBZq3fL85hQ&r=wwc_Z_TbmWbPFh7My2zRxmrGgCNO-71Fwzlmd8YZVUY&m=RvJme-Yx-ZSHHLq6YYhRqhUbUDn1Qw8U3V5FHldmWMs&s=_J1fVaiELVB9BypZT9mGfPz2OMQqJDVi9RUK4jIW_ag&e=>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lyralists.lyrasis.org/pipermail/archivesspace_users_group/attachments/20160328/8c106474/attachment.html>

More information about the Archivesspace_Users_Group mailing list