<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body>
<br>
Thanks, Steven!<br>
<br>
Is the '<span style="font-variant-ligatures: no-common-ligatures"
class="">identifier_for_search_result' method (below) the drop in
replacement for the now-removed 'show_identifier_column' method?<br>
<br>
Mark<br>
</span>
<pre class="moz-signature" cols="72"><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
Mark Cyzyk, M.A., M.L.S.
Library Applications Group
The Sheridan Libraries
The Johns Hopkins University
<a class="moz-txt-link-abbreviated" href="mailto:mcyzyk@jhu.edu">mcyzyk@jhu.edu</a>
Verba volant, scripta manent.
</pre>
<div class="moz-cite-prefix">On 9/14/20 4:36 PM, Majewski, Steven
Dennis (sdm7g) wrote:<br>
</div>
<blockquote type="cite"
cite="mid:0BC58F2A-4161-476D-AEA2-337AF9FABD2E@virginia.edu">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div class="">Looks like the docs must have slipped behind the
changes.</div>
<div class=""><br class="">
</div>
git log -p frontend/app/helpers/search_helper.rb <br class="">
<div><br class="">
</div>
<div>Shows that function removed, I assume as part of the many
search changes in v2.8.0 </div>
<div><br class="">
</div>
<div><br class="">
</div>
<div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(223, 189, 34); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""><b
class="">diff --git
a/frontend/app/helpers/search_helper.rb
b/frontend/app/helpers/search_helper.rb</b></span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(223, 189, 34); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""><b
class="">index a192965ee..c5a371cc0 100644</b></span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(223, 189, 34); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""><b
class="">--- a/frontend/app/helpers/search_helper.rb</b></span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(223, 189, 34); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""><b
class="">+++ b/frontend/app/helpers/search_helper.rb</b></span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures; color:
#4ed2e0" class="">@@ -18,12 +18,32 @@</span><span
style="font-variant-ligatures: no-common-ligatures" class="">
module SearchHelper</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
"subject" => "authority_id",</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
}</span></div>
<p style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098); min-height: 19px;" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""> </span><br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
def identifier_for_search_result(result)</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
identifier =
IDENTIFIER_FOR_SEARCH_RESULT_LOOKUP.fetch(result["primary_type"],
"")</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
unless identifier.empty?</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
if result.has_key? identifier</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
identifier = result[identifier]</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
else</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
json = ASUtils.json_parse(result["json"])</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
identifier = json.fetch(identifier, "")</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
end</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
end</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
identifier.to_s.html_safe</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
end</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
def build_search_params(opts = {})</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
removing_record_type_filter = false</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
Array(opts["remove_filter_term"]).each do |filter_term|</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
removing_record_type_filter = true if
ASUtils.json_parse(filter_term).keys.include? 'primary_type'</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
end</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
search_params = {}</span></div>
<p style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098); min-height: 19px;" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""> </span><br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
search_params["filter_term"] = Array(opts["filter_term"]
|| params["filter_term"]).clone</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
search_params["filter_term"].concat(Array(opts["add_filter_term"]))
if opts["add_filter_term"]</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
search_params["filter_term"] =
search_params["filter_term"].reject{|f|
Array(opts["remove_filter_term"]).include?(f)} if
opts["remove_filter_term"]</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
search_params["filter_term"] =
search_params["filter_term"].select{|f|
SearchResultData.BASE_FACETS.include?(ASUtils.json_parse(f).keys.first)}
if removing_record_type_filter</span></div>
<p style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098); min-height: 19px;" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""> </span><br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
if params["multiplicity"]</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
search_params["multiplicity"] = params["multiplicity"]</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures; color:
#4ed2e0" class="">@@ -31,19 +51,12 @@</span><span
style="font-variant-ligatures: no-common-ligatures" class="">
module SearchHelper</span></div>
<p style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098); min-height: 19px;" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""> </span><br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
sort = (opts["sort"] || params["sort"])</span></div>
<p style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098); min-height: 19px;" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""> </span><br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">- if
show_identifier_column?</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">-
search_params["display_identifier"] = true</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">- end</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">-</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">- # if the browse list was
sorted by default</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">- if sort.nil? &&
!@search_data.nil? && @search_data.sorted?</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">- sort =
@search_data[:criteria]["sort"]</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">- end</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">-</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
if sort</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
sort = sort.split(', ')</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
sort[1] = opts["sort2"] if opts["sort2"]</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(86, 0, 1); background-color: rgba(122, 37,
30, 0.85098);" class=""><span style="font-variant-ligatures:
no-common-ligatures" class="">- search_params["sort"] =
sort.uniq.join(', ')</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
fields = sort.uniq</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
fields = fields.select {|f|
multi_columns.compact.include?(f.split.first)} if
removing_record_type_filter</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(80, 219, 57); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">+
search_params["sort"] = fields.join(', ')</span></div>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
end</span></div>
<p style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098); min-height: 19px;" class=""><span
style="font-variant-ligatures: no-common-ligatures" class=""> </span><br
class="webkit-block-placeholder">
</p>
<div style="margin: 0px; font-stretch: normal; line-height:
normal; color: rgb(205, 190, 151); background-color: rgba(122,
37, 30, 0.85098);" class=""><span
style="font-variant-ligatures: no-common-ligatures" class="">
if (opts["format"] || params["format"]).blank?</span></div>
<div class=""><span style="font-variant-ligatures:
no-common-ligatures" class=""><br class="">
</span></div>
</div>
<div><br class="">
</div>
<div><br class="">
</div>
<div><br class="">
</div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Sep 14, 2020, at 4:05 PM, Mark Cyzyk <<a
href="mailto:mcyzyk@jhu.edu" class=""
moz-do-not-send="true">mcyzyk@jhu.edu</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class=""><br class="">
Dear Aspace List,<br class="">
<br class="">
Here is a puzzler:<br class="">
<br class="">
One of our custom plugins is throwing an error with ASpace
2.8.0:<br class="">
<br class="">
<blockquote type="cite" class="">I,
[2020-09-14T18:31:21.347591 #1711] INFO -- : Rendered
shared/_breadcrumb.html.erb (3729.1ms)<br class="">
I, [2020-09-14T18:31:21.551547 #1711] INFO -- :
Rendered search/_filter.html.erb (187.7ms)<br class="">
I, [2020-09-14T18:31:23.178717 #1711] INFO -- :
Rendered
/usr/share/archivesspace/plugins/staff_mode_search/frontend/views/search/_listing.html.erb
(1380.8ms)<br class="">
I, [2020-09-14T18:31:23.188677 #1711] INFO -- :
Rendered search/_results.html.erb (1834.8ms)<br class="">
I, [2020-09-14T18:31:23.191373 #1711] INFO -- :
Rendered search/do_search.html.erb within
layouts/application (5600.4ms)<br class="">
I, [2020-09-14T18:31:23.193788 #1711] INFO -- :
Completed 500 Internal Server Error in 8777ms<br
class="">
F, [2020-09-14T18:31:23.238453 #1711] FATAL -- :<br
class="">
F, [2020-09-14T18:31:23.238827 #1711] FATAL -- :
ActionView::Template::Error (undefined method
`show_identifier_column?' for
#<#<Class:0x36821e2c>:0x5ccfe41e><br
class="">
Did you mean? show_external_ids?):<br class="">
F, [2020-09-14T18:31:23.251369 #1711] FATAL -- : 6:
%><br class="">
7:<br class="">
8: <% if @search_data.results? %><br class="">
9: <% add_identifier_column if
show_identifier_column? %><br class="">
10: <%= render_aspace_partial :partial =>
"shared/pagination_summary" %><br class="">
11:<br class="">
12: <table id="tabledSearchResults"
class="table table-striped table-bordered
table-condensed table-hover table-sortable
table-search-results" <% if allow_multi_select?
%>data-multiselect="true"<% end %>><br
class="">
F, [2020-09-14T18:31:23.251910 #1711] FATAL -- :<br
class="">
F, [2020-09-14T18:31:23.252256 #1711] FATAL -- :
app/helpers/application_helper.rb:307:in
`render_aspace_partial'<br class="">
app/views/search/_results.html.erb:22:in
`_app_views_search__results_html_erb___900220805_2354'<br
class="">
app/helpers/application_helper.rb:307:in
`render_aspace_partial'<br class="">
app/views/search/do_search.html.erb:16:in
`_app_views_search_do_search_html_erb___1615232398_2350<br
class="">
</blockquote>
<br class="">
The key line here is, I think:<br class="">
<br class="">
<blockquote type="cite" class="">F,
[2020-09-14T18:31:23.238827 #1711] FATAL -- :
ActionView::Template::Error (undefined method
`show_identifier_column?' for
#<#<Class:0x36821e2c>:0x5ccfe41e><br
class="">
Did you mean? show_external_ids?):<br class="">
</blockquote>
<br class="">
No, I didn't mean "show_external_ids'!<br class="">
<br class="">
The docs do indeed list 'show_identifier_column?' as a
method.
(/archivesspace/docs/doc/SearchHelper.html#show_identifier_column%3F-instance_method)<br
class="">
<br class="">
Does anyone have an idea about why ASpace 2.8.0 might be
throwing this error when this method is called?<br
class="">
<br class="">
Much appreciated,<br class="">
<br class="">
Mark<br class="">
<br class="">
-- <br class="">
<><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><br
class="">
Mark Cyzyk, M.A., M.L.S.<br class="">
Library Applications Group<br class="">
The Sheridan Libraries<br class="">
The Johns Hopkins University<br class="">
<a href="mailto:mcyzyk@jhu.edu" class=""
moz-do-not-send="true">mcyzyk@jhu.edu</a><br class="">
<br class="">
Verba volant, scripta manent.<br class="">
<br class="">
_______________________________________________<br
class="">
Archivesspace_Users_Group mailing list<br class="">
<a class="moz-txt-link-abbreviated" href="mailto:Archivesspace_Users_Group@lyralists.lyrasis.org">Archivesspace_Users_Group@lyralists.lyrasis.org</a><br
class="">
<a class="moz-txt-link-freetext" href="http://lyralists.lyrasis.org/mailman/listinfo/archivesspace_users_group">http://lyralists.lyrasis.org/mailman/listinfo/archivesspace_users_group</a><br
class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</blockquote>
<br>
</body>
</html>