[Archivesspace_Users_Group] Archivesspace bug fix AR-1421

[Majewski, Steven Dennis (sdm7g)]

> On Aug 5, 2016, at 11:24 AM, Majewski, Steven (sdm7g) <sdm7g at eservices.virginia.edu> wrote:
> 
> 
> 
> If you click on that link to the pull request at the bottom of that JIRA report, and then click on ‘Files Changed’, you’ll get more context. The patch is to:  backend/app/converters/lib/xml_sax.rb
> 
> 
> https://github.com/archivesspace/archivesspace/pull/378/files#diff-bde3a5de240aa28035e6a6e84443c761L229
> 
> 
> You would either need to get the 1.4.2 source distribution, patch that file and build distribution, or if you’ve cloned the git project, you might find the commit with that patch and build from there. 
> 

It looks like I never deleted that branch after patch was accepted, so alternatively, you could pull from:

https://github.com/uvalib/archivesspace/tree/AR-1421


Looking at the releases: https://github.com/archivesspace/archivesspace/releases
it appears that AR-1421 didn’t go in to release until 1.5.0, so if you’re not ready for the big upgrade and you need to stay on 1.4.x, there’s not a simple way to avoid building your own. Maybe you could replace that file in backend.war ? 


> I’m not sure how simple it would be to package that file up as a local plugin to avoid having to build a distribution from sources.  I ran into (solvable) complications trying to override methods in the frontend rails app due to rails lazy loading of classes. But the backend is in Sinatra, so it may be simpler. 
> 
> 
> — Steve Majewski / UVA Alderman Library
> 
> 
>> On Aug 5, 2016, at 11:04 AM, David M. ZUCKERMAN <dzuckerm at library.berkeley.edu> wrote:
>> 
>> Hi,
>> 
>> I had sent this email to Chris Fitzpatrick but I understand he is no longer with archivesspace so perhaps someone else could answer my question.
>> 
>> 
>> 
>> I see this fix was put in place for a demo release of Archivesspace. Is it possible for us to incorporate this fix in our current release V1.4.2?
>> 
>> I see Chris  included a snippet of code that fixes the problem but I’m not sure where it would go.
>> 
>> @@ -226,7 +231,7 @@ module ASpaceImport
>>       end
>> 
>>       def pprint_current_node
>> -        Nokogiri::XML::Builder.new {|b|
>> +        Nokogiri::XML::Builder.new( :encoding => 'UTF-8' ) {|b|
>>           b.send(@node.name.intern, @node.attributes).cdata(" ... ")
>>         }.doc.root.to_s
>>       end
>> 
>> 
>> Thanks,
>> Dave
>> 
>> 
>> https://archivesspace.atlassian.net/browse/AR-1421
>> 
>> _______________________________________________
>> Archivesspace_Users_Group mailing list
>> Archivesspace_Users_Group at lyralists.lyrasis.org
>> http://lyralists.lyrasis.org/mailman/listinfo/archivesspace_users_group
>