[Archivesspace_Users_Group] Archivesspace bug fix AR-1421

[David M. ZUCKERMAN]

Hi Steven,

Thanks for the answer. I was actually able to find the extracted source in
/data/tmp/jetty-0.0.0.0-8089-backend.war/.......

I'm a rails newbie but I assume the war file gets extracted at run time and
the current instance of archivesspace would use the code in /data/tmp.

If that's accurate could I try editing the pprint_current_node within the
/data/tmp directory (while archivesspace is running) just to see if the fix
clears our problem. If it does then I'd see about rebuilding from source as
you suggest.

Thanks!
Dave

-----Original Message-----
From: Majewski, Steven Dennis (sdm7g) [mailto:sdm7g at eservices.virginia.edu]
Sent: Friday, August 05, 2016 8:24 AM
To: Archivesspace Users Group
Cc: dzuckerm at library.berkeley.edu
Subject: Re: [Archivesspace_Users_Group] Archivesspace bug fix AR-1421



If you click on that link to the pull request at the bottom of that JIRA
report, and then click on ‘Files Changed’, you’ll get more context. The
patch is to:  backend/app/converters/lib/xml_sax.rb


https://github.com/archivesspace/archivesspace/pull/378/files#diff-bde3a5de240aa28035e6a6e84443c761L229


You would either need to get the 1.4.2 source distribution, patch that file
and build distribution, or if you’ve cloned the git project, you might find
the commit with that patch and build from there.

I’m not sure how simple it would be to package that file up as a local
plugin to avoid having to build a distribution from sources.  I ran into
(solvable) complications trying to override methods in the frontend rails
app due to rails lazy loading of classes. But the backend is in Sinatra, so
it may be simpler.


— Steve Majewski / UVA Alderman Library


> On Aug 5, 2016, at 11:04 AM, David M. ZUCKERMAN
> <dzuckerm at library.berkeley.edu> wrote:
>
> Hi,
>
> I had sent this email to Chris Fitzpatrick but I understand he is no
> longer with archivesspace so perhaps someone else could answer my
> question.
>
>
>
> I see this fix was put in place for a demo release of Archivesspace. Is it
> possible for us to incorporate this fix in our current release V1.4.2?
>
> I see Chris  included a snippet of code that fixes the problem but I’m not
> sure where it would go.
>
> @@ -226,7 +231,7 @@ module ASpaceImport
>        end
>
>        def pprint_current_node
> -        Nokogiri::XML::Builder.new {|b|
> +        Nokogiri::XML::Builder.new( :encoding => 'UTF-8' ) {|b|
>            b.send(@node.name.intern, @node.attributes).cdata(" ... ")
>          }.doc.root.to_s
>        end
>
>
> Thanks,
> Dave
>
>
> https://archivesspace.atlassian.net/browse/AR-1421
>
> _______________________________________________
> Archivesspace_Users_Group mailing list
> Archivesspace_Users_Group at lyralists.lyrasis.org
> http://lyralists.lyrasis.org/mailman/listinfo/archivesspace_users_grou
> p