[Archivesspace_Users_Group] reordering objects in resource records

[Payten Giles]

Hi there Chris, Allyson,

Eavesdropping a little bit and the guilt of writing this code became too much! 

Chris, this looks like a little bug in the tree.js where we aren’t checking the correct node.. the comment says the right thing while the code does the wrong thing.  Here’s a gist of a potential patch:

https://gist.github.com/payten/649819e7f08d0de3e945 <https://gist.github.com/payten/649819e7f08d0de3e945>

To replicate I have a Resource hierarchy something like this:

- Resource 
	- AO Parent
		- AO Child 1
		- AO Child 2
		- AO Child 3
		- AO Child 4

I select and go to edit ‘AO Child 3’.  When that form is visible I drag ‘AO Child 4’ above to become the first sibling.  I then continue to edit ‘AO Child 3’ and refresh the page.  ‘A0 Child 3’ is now positioned directly under ‘Resource’.

Happy to put together a more formal pull request if you like.

Cheers,
Payten

> On 11 Nov 2014, at 12:53 am, Chris Fitzpatrick <Chris.Fitzpatrick at lyrasis.org> wrote:
> 
> Hi Allyson,
> 
> Unfortuantely, I haven't been able to replicate the problem of component movements not sticking. See =>
> https://drive.google.com/file/d/0BzRF7huQ7tqKS29oM2RZZWNubGc/view?usp=sharing <https://drive.google.com/file/d/0BzRF7huQ7tqKS29oM2RZZWNubGc/view?usp=sharing> )
> 
> In edit mode, I'm able to drag and drop components, reload the page, or go to the view page.
> 
> Is this happening for every record every time for you? Or is it an infrequent thing?
> 
> Not doubting you ( I promise! ) , just trying to see when this is happening...
> 
> b,chris. 
> 
> Chris Fitzpatrick | Developer, ArchivesSpace
> Skype: chrisfitzpat  | Phone: 918.236.6048
> http://archivesspace.org/ <http://archivesspace.org/>
> From: archivesspace_users_group-bounces at lyralists.lyrasis.org <archivesspace_users_group-bounces at lyralists.lyrasis.org> on behalf of Allyson Smally <asmally at colgate.edu>
> Sent: Friday, November 07, 2014 6:04 PM
> To: Archivesspace Users Group
> Subject: Re: [Archivesspace_Users_Group] reordering objects in resource records
>  
> Hello all -
> 
> Unfortunately, after upgrading to the newest release, we are still having this problem.
> Archival objects are reordering themselves after being edited.
> 
> Is anyone else still having this problem? Does anyone know of a solution?
> 
> Thanks very much,
> Allyson
> 
> Allyson E. Smally
> Processing Archivist
> Colgate University Libraries
> 13 Oak Drive
> Hamilton, NY 13346
> (315) 228-7867
> 
> On Thu, Sep 25, 2014 at 8:14 AM, Ben Goldman <bmg17 at psu.edu <mailto:bmg17 at psu.edu>> wrote:
> Hi Chris,
> 
> Archival object tree. 
> 
> Thanks!
> -Ben
> 
> From: "Chris Fitzpatrick" <Chris.Fitzpatrick at lyrasis.org <mailto:Chris.Fitzpatrick at lyrasis.org>>
> To: "Archivesspace Users Group" <archivesspace_users_group at lyralists.lyrasis.org <mailto:archivesspace_users_group at lyralists.lyrasis.org>>
> Sent: Thursday, September 25, 2014 3:46:10 AM
> 
> Subject: Re: [Archivesspace_Users_Group] reordering objects        in        resource        records
> 
> Hey Ben,
> 
> Soon, I promise!
> 
> But just to check, are you talking about reording the archival object tree for the resource or the order of things like notes and subjects?
> 
> b,chris. 
> 
> Chris Fitzpatrick | Developer, ArchivesSpace
> Skype: chrisfitzpat  | Phone: 918.236.6048 <tel:918.236.6048>
> http://archivesspace.org/ <http://archivesspace.org/>
> From: archivesspace_users_group-bounces at lyralists.lyrasis.org <mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org> <archivesspace_users_group-bounces at lyralists.lyrasis.org <mailto:archivesspace_users_group-bounces at lyralists.lyrasis.org>> on behalf of Ben Goldman <bmg17 at psu.edu <mailto:bmg17 at psu.edu>>
> Sent: Tuesday, September 23, 2014 10:19 PM
> To: Archivesspace Users Group
> Subject: Re: [Archivesspace_Users_Group] reordering objects in resource records
>  
> Thanks, Allyson. I knew it sounded familiar!
> 
> Do we have an ETA on the next release yet? :)
> 
> -Ben
> 
> From: "Allyson Smally" <asmally at colgate.edu <mailto:asmally at colgate.edu>>
> To: "Archivesspace Users Group" <archivesspace_users_group at lyralists.lyrasis.org <mailto:archivesspace_users_group at lyralists.lyrasis.org>>
> Sent: Tuesday, September 23, 2014 4:15:04 PM
> Subject: Re: [Archivesspace_Users_Group] reordering objects in resource        records
> 
> Hi Ben,
> 
> Yes, from what I understand this is a known issue. It has been happening to us a lot as well.
> At SAA this August, I was told it would be fixed in the next release.
> 
> -Allyson
> 
> Allyson E. Smally
> Processing Archivist
> Colgate University Libraries
> 13 Oak Drive
> Hamilton, NY 13346
> (315) 228-7867 <tel:%28315%29%20228-7867>
> 
> On Tue, Sep 23, 2014 at 2:52 PM, Ben Goldman <bmg17 at psu.edu <mailto:bmg17 at psu.edu>> wrote:
> Hello,
> 
> I've just experienced an issue and on a cursory search can't tell if it's been noted in PivotalTracker yet or discussed here yet.
> 
> I've been editing an inventory object-by-object in a resource record, saving each object as I updated it. In one instance I reordered one of the objects by dragging it further down the tree, then continued editing other objects. Then I reached an object that could be removed, clicked to delete it,  the resource reloaded in View mode, and the objects appeared to shuffle, and not seemingly in the order I started with. 
> 
> -Ben
> 
> Ben Goldman
> Digital Records Archivist
> Penn State University Libraries
> University Park, PA
> 814-863-8333 <tel:814-863-8333>
> http://www.libraries.psu.edu/psul/speccolls.html <http://www.libraries.psu.edu/psul/speccolls.html>
> 
> 
> 
> -- 
> Allyson E. Smally
> Processing Archivist
> Colgate University Libraries
> 13 Oak Drive
> Hamilton, NY 13346
> (315) 228-7867
> _______________________________________________
> Archivesspace_Users_Group mailing list
> Archivesspace_Users_Group at lyralists.lyrasis.org
> http://lyralists.lyrasis.org/mailman/listinfo/archivesspace_users_group

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lyralists.lyrasis.org/pipermail/archivesspace_users_group/attachments/20141112/a931ffe7/attachment.html>